-
Notifications
You must be signed in to change notification settings - Fork 1
build: set vaadin dependency to 14.11.13 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated Maven dependencies in pom.xml: Vaadin platform version bumped from 14.7.7 to 14.11.13, and webdrivermanager dependency updated from 3.8.1 to 6.3.2. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pom.xml(2 hunks)
🔇 Additional comments (1)
pom.xml (1)
143-143: WebDriverManager 6.3.2 upgrade is API-compatible; verify driver resolution via test execution.The codebase uses
WebDriverManager.chromedriver().setup()inAbstractViewTest.javaline 62, which remains supported in v6.3.2. This backward-compatible pattern continues to work in v5/v6. No deprecated methods, custom configurations, or advanced APIs are evident.However, driver-resolution endpoints and algorithms changed starting in v5/v6; cached-driver resolution behavior may differ and tests that relied on old resolution/cached binaries may get different driver versions. Run the integration test suite to confirm the resolved driver versions are compatible with your environment and Vaadin TestBench. Optionally, clear the local driver cache before testing to ensure clean resolution with v6.3.2 logic. An XXE vulnerability (CVE-2025-4641) affecting versions before 6.1.0 was fixed, making this a security improvement.



Summary by CodeRabbit